-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove explicit repo name loading local bzl files #2485
Conversation
299e557
to
7de57c6
Compare
load("//apple/internal:providers.bzl", "new_appleplatforminfo") | ||
load("//apple:providers.bzl", "ApplePlatformInfo") | ||
load("@bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain", "use_cpp_toolchain") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After doing this, can you reorder the loads? Relative ones should be below external ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related: I noticed buildifier isn't run on PR's here. By design or should that be added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's checked in buildkite/rules-apple-darwin/pr/buildifier
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Though maybe it's not as strict as it should be.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make the sorts another PR, and if I see a buildifier fix I'll include that with it.
c2fd7e3
to
91d355a
Compare
|
Followup request from #2485 rules_apple is on buildifier 6.3.2, one version before load sorting improvements. Can update that too.
Removes explicit repo names in load commands in favor of relative names.